Fix mechanical arm animation in ponder#10161
Open
JensenJ wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
Open
Fix mechanical arm animation in ponder#10161JensenJ wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
JensenJ wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
Conversation
VoidLeech
added
pr type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
This fixes #8925.
In my testing removing this check has no negative consequences (aside from a little extra computation), but I might be overlooking or misunderstanding something about what this check does.
Basically the cause of the bug was that when we read the new target data from NBT (which ponder relies on when setting instructions), the previous target and existing angle are not taken into account as this check skips their calculation. The arm then assumes it is starting from it's default rotation (as the previous angle is never set), and thus snaps back.
Thanks